CMS Pixel Detector Miscellaneous
Phase 1 Phase 2
Layer 1 Replacement Layers 2-4
  Layer 1 Replacement Elog  Not logged in ELOG logo
 List  |  Find  |  Login  |  Help 
Entry  Thu Apr 30 16:47:00 2020, Matej Roguljic, Software, MoReWeb empty DAC plots 
    Reply  Thu Apr 30 17:24:57 2020, Dinko Ferencek, Software, MoReWeb empty DAC plots 
    Reply  Thu Apr 30 17:33:04 2020, Andrey Starodumov, Software, MoReWeb empty DAC plots 
       Reply  Thu May 7 00:10:15 2020, Dinko Ferencek, Software, MoReWeb empty DAC plots 
Message ID: 244     Entry time: Thu Apr 30 17:24:57 2020     In reply to: 243
Author: Dinko Ferencek 
Category: Software 
Subject: MoReWeb empty DAC plots 

Matej Roguljic wrote:
Some of the DAC parameters plots were empty in the production overview page. All the empty plots had the number "35" in them (e.g. DAC distribution m20_1 vana 35). The problem was tracked down to the trimming configuration. Moreweb was expecting us to trim to Vcal 35, while we decided to trim to Vcal 50. I "grepped" where this was hardcoded and changed 35->50.

The places where I made changes:
  • Analyse/AbstractClasses/TestResultEnvironment.py
    'trimThr':35
  • Analyse/Configuration/GradingParameters.cfg.default
    trimThr = 35
  • Analyse/OverviewClasses/CMSPixel/ProductionOverview/ProductionOverviewPage/ProductionOverviewPage.py
    TrimThresholds = ['', '35']
  • Analyse/OverviewClasses/CMSPixel/ProductionOverview/ProductionOverviewPage/ProductionOverviewPage.py
    self.SubPages.append({"InitialAttributes" : {"Anchor": "DACDSpread35", "Title": "DAC parameter spread per module - 35"}, "Key": "Section","Module": "Section"})


It's interesting to note that someone had already made the change in "Analyse/Configuration/GradingParameters.cfg"


As far as I can remember, the changes in Analyse/AbstractClasses/TestResultEnvironment.py, Analyse/Configuration/GradingParameters.cfg.default and Analyse/Configuration/GradingParameters.cfg were there from before, probably made by Andrey. It is possible that you looked at the files when I was preparing logically separate commits affecting the same files which required temporarily undoing and later reapplying some of the changes to be able to separate the commits. The commits are now on GitLab https://gitlab.cern.ch/CMS-IRB/MoReWeb/-/commits/L1replacement, specifically:

435ffb98: grading parameters related to the trimming threshold updated from 35 to 50 VCal units
1987ff18: updates in the production overview page related to a change in the trimming threshold
ELOG V3.1.3-7933898